Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Prevent error when overlay is not available #4244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUGFIX] Prevent error when overlay is not available #4244

wants to merge 1 commit into from
+6 −1

Conversation

magicsunday
Copy link

This fixes:

Core: Error handler (BE): PHP Warning: Trying to access array offset on value of type null in /var/www/vendor/apache-solr-for-typo3/solr/Classes/ContentObject/Relation.php line 311

What this pr does

Please add a description here

How to test

Please add a testing instruction here

Fixes: #issue (Please create an related issue first and mark it as fixed here with your pr)

@dkd-kaehm dkd-kaehm force-pushed the patch-1 branch 2 times, most recently from d9f3b15 to f2cafde Compare December 11, 2024 09:33
@dkd-kaehm
Copy link
Collaborator

@magicsunday
Thanks for fixing that issue please check following error
by https://github.com/TYPO3-Solr/ext-solr/actions/runs/12273510045/job/34244520075#step:10:78:

 ------ ----------------------------------------------------------------------------- 
  Line   Classes/ContentObject/Relation.php                                           
 ------ ----------------------------------------------------------------------------- 
  306    Method                                                                       
         ApacheSolrForTypo3\Solr\ContentObject\Relation::getFrontendOverlayService()  
         invoked with 1 parameter, 0 required.                                        
  313    Variable $overlayRelatedRecord might not be defined.                         
 ------ -----------------------------------------------------------------------------

@magicsunday @dkd-kaehm
[BUGFIX] Prevent error when overlay is not available
1dcf85d 
This fixes:

Core: Error handler (BE): PHP Warning: Trying to access array offset on value of type null in /var/www/vendor/apache-solr-for-typo3/solr/Classes/ContentObject/Relation.php line 311
@dkd-kaehm
Copy link
Collaborator

Currently fixed the PHPstan issue, but do not merge it.
Relation MUST NOT always fallback to default language, but accept null as well.
Also it must follow the TYPO3s language modies(fallback, strict, free).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magicsunday @dkd-kaehm